Bug 60282 - [Chromium] Remove non-flaky tests and skip one unsupported test in test expectation file (BUGCR81682, BUGCR80067, BUGCR59399).
Summary: [Chromium] Remove non-flaky tests and skip one unsupported test in test expec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 11:27 PDT by imasaki
Modified: 2011-05-05 17:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.27 KB, application/octet-stream)
2011-05-05 11:42 PDT, imasaki
no flags Details
Patch (3.27 KB, patch)
2011-05-05 11:49 PDT, imasaki
jianli: review-
Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2011-05-05 14:56 PDT, imasaki
jianli: review-
Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2011-05-05 16:47 PDT, imasaki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description imasaki 2011-05-05 11:27:38 PDT
[Chromium] Remove non-flaky tests and skip one unsupported test in test expectation file (BUGCR81682, BUGCR80067, BUGCR59399).
Comment 1 imasaki 2011-05-05 11:42:57 PDT
Created attachment 92437 [details]
Patch
Comment 2 imasaki 2011-05-05 11:49:45 PDT
Created attachment 92439 [details]
Patch
Comment 3 Jian Li 2011-05-05 13:53:29 PDT
Comment on attachment 92439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92439&action=review

> LayoutTests/ChangeLog:7
> +        - this cliking test is specific to Mac.

The above line seems not to be part of the description. Please move it to the detail section that lies below the bug link.
Comment 4 imasaki 2011-05-05 14:56:39 PDT
Created attachment 92477 [details]
Patch
Comment 5 imasaki 2011-05-05 14:57:10 PDT
Comment on attachment 92477 [details]
Patch

updated ChangeLog comment based on feedback.
Comment 6 Jian Li 2011-05-05 16:39:59 PDT
Comment on attachment 92477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92477&action=review

> LayoutTests/ChangeLog:8
> +        (Chrome Video Stack team) decided not to support it.

The above 2 lines should be better moved below the bug link like:
  [Chromium] Remove non-flaky ...
  https://bugs.webkit.org/show_bug.cgi?id=60282

  The skipped test is a cliking test that ...
Comment 7 imasaki 2011-05-05 16:47:17 PDT
Created attachment 92497 [details]
Patch
Comment 8 WebKit Commit Bot 2011-05-05 17:19:47 PDT
Comment on attachment 92497 [details]
Patch

Clearing flags on attachment: 92497

Committed r85904: <http://trac.webkit.org/changeset/85904>
Comment 9 WebKit Commit Bot 2011-05-05 17:19:52 PDT
All reviewed patches have been landed.  Closing bug.