Bug 60204 - Adding myself to committers list in committers.py.
Summary: Adding myself to committers list in committers.py.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Guillory
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 13:05 PDT by Chris Guillory
Modified: 2011-07-06 17:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch (836 bytes, patch)
2011-05-04 13:05 PDT, Chris Guillory 		no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2011-07-06 15:15 PDT, Chris Guillory 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Guillory 2011-05-04 13:05:52 PDT 
Created attachment 92305 [details]
Patch

Adding myself to Chromium contributors list in committers.py.
Comment 1 WebKit Commit Bot 2011-05-04 17:02:45 PDT 
Comment on attachment 92305 [details]
Patch

Rejecting attachment 92305 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'la..." exit_code: 2

Last 500 characters of output:
M	LayoutTests/fast/harness/resources/results-test.js
	M	LayoutTests/fast/harness/results-expected.txt
	M	LayoutTests/ChangeLog
r85809 = f105d5d491ebafec63a895f988fe306c6af642a1 (refs/remotes/trunk)
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/rendering/RenderBlockLineLayout.cpp
	M	Source/WebCore/rendering/RenderBlock.h
r85810 = 1a50869fae6e43b842f1d684424367bfba24c769 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded new_master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8557727
Comment 2 David Levin 2011-05-04 17:03:58 PDT 
Comment on attachment 92305 [details]
Patch

Whoops, no changelog.
Comment 3 Alexey Proskuryakov 2011-05-04 17:06:50 PDT 
As a comment in this file says, no review needed. This is because the list about a committer who wants to have someone in the autocomplete list to make CC'ing them easier, not about someone wanting to be on the list.
Comment 4 David Levin 2011-05-04 17:15:40 PDT 
Actually, Chris you should just get someone to nominate you as a committer.

It looks like you have at least 22 patches : http://trac.webkit.org/search?q=chris.guillory&noquickjump=1&changeset=on
Comment 5 Chris Guillory 2011-07-06 14:27:49 PDT 
I'm now a comitter but still need to be added to Tools/Scripts/webkitpy/common/config/committers.py.
Comment 6 David Levin 2011-07-06 14:53:48 PDT 
(In reply to comment #5)
> I'm now a comitter but still need to be added to Tools/Scripts/webkitpy/common/config/committers.py.

If you have commit privileges, then put up a patch with yourself in the committers section (and a ChangeLog). I'd be happy to r+, cq+.
Comment 7 Chris Guillory 2011-07-06 15:15:10 PDT 
Created attachment 99891 [details]
Patch
Comment 8 Chris Guillory 2011-07-06 15:31:05 PDT 
I'm going to attempt to land this using my local checkout. I don't believe a review is required for the change to committers.py. I've uploaded the patch I plan to land.
Comment 9 Chris Guillory 2011-07-06 17:36:51 PDT 
Committed r90519: <http://trac.webkit.org/changeset/90519>