Bug 60162 - [NRWT] chromium-linux tests shouldn't run on other platforms
Summary: [NRWT] chromium-linux tests shouldn't run on other platforms
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kristóf Kosztyó
Keywords: Qt, QtTriaged
Depends on:
Blocks: 34984
  Show dependency treegraph
Reported: 2011-05-04 05:56 PDT by Csaba Osztrogonác
Modified: 2011-05-13 07:49 PDT (History)
3 users (show)

See Also:

proposed fix (3.49 KB, patch)
2011-05-13 07:40 PDT, Kristóf Kosztyó
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-05-04 05:56:42 PDT
These tests run, but they shouldn't:


Gábor, could you check it, please?
Comment 1 Kristóf Kosztyó 2011-05-13 07:40:31 PDT
Created attachment 93449 [details]
proposed fix
Comment 2 Csaba Osztrogonác 2011-05-13 07:43:49 PDT
Comment on attachment 93449 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=93449&action=review

LGTM, r=me with a little fix in changelog

> Tools/ChangeLog:9
> +        Remove _tests_for_other_platforms defs because in the r82753
> +        it is implemented properly in the baseclass in webkit.py

little nit: ... because r82753 implemented it properly ...
Comment 3 Csaba Osztrogonác 2011-05-13 07:48:57 PDT
Landed in http://trac.webkit.org/changeset/86429