Bug 59936 - Port Mozilla's IndexedDB tests: inline autoincrement key added on put
Summary: Port Mozilla's IndexedDB tests: inline autoincrement key added on put
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 07:14 PDT by Mark Pilgrim (Google)
Modified: 2011-05-02 14:03 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.27 KB, patch)
2011-05-02 07:16 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-05-02 07:14:46 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_objectStore_inline_autoincrement_key_added_on_put.html?force=1

This is a port of a test from Mozilla's IndexedDB test suite. It adds a record with an autoincremented key and then retrieves the record by key and verifies that all data matches expected values.

WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-05-02 07:16:59 PDT
Created attachment 91923 [details]
Patch
Comment 2 Tony Chang 2011-05-02 12:17:57 PDT
Comment on attachment 91923 [details]
Patch

OK
Comment 3 WebKit Commit Bot 2011-05-02 13:30:49 PDT
The commit-queue encountered the following flaky tests while processing attachment 91923 [details]:

http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2011-05-02 13:32:28 PDT
Comment on attachment 91923 [details]
Patch

Clearing flags on attachment: 91923

Committed r85514: <http://trac.webkit.org/changeset/85514>
Comment 5 WebKit Commit Bot 2011-05-02 13:32:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Hin-Chung Lam 2011-05-02 13:49:57 PDT
Committed r85517: <http://trac.webkit.org/changeset/85517>
Comment 7 Hin-Chung Lam 2011-05-02 13:52:08 PDT
webkit-patch land caused this bug to be marked as closed.
Comment 8 Hin-Chung Lam 2011-05-02 13:55:56 PDT
Somehow due to update-webkit mystery I committed this patch for you.
Comment 9 Hin-Chung Lam 2011-05-02 13:56:12 PDT
I mean webkit-patch.
Comment 10 Mark Pilgrim (Google) 2011-05-02 13:59:06 PDT
Well thanks, I guess. :) It was on its way to being committed anyway, so no harm done, I suppose. Mark as RESOLVED FIXED?
Comment 11 Hin-Chung Lam 2011-05-02 13:59:39 PDT
Yes please do.
Comment 12 Tony Chang 2011-05-02 14:03:26 PDT
hclam: webkit-patch was confused because your ChangeLog description was not at the top of the file (maybe it got merged wrong).  This change was already landed by the time your change went in.