Bug 59888 - [android] OS(ANDROID) does not imply PLATFORM(ANDROID)
Summary: [android] OS(ANDROID) does not imply PLATFORM(ANDROID)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Holger Freyther
URL:
Keywords:
Depends on:
Blocks: 60907
  Show dependency treegraph
 
Reported: 2011-05-01 13:55 PDT by Holger Freyther
Modified: 2011-05-16 10:55 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2011-05-01 13:59 PDT, Holger Freyther
steveblock: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2011-05-01 13:55:47 PDT
It is possible to build other ports for the Android Operating System as well. PLATFORM(ANDROID) should not be automatically enabled.
Comment 1 Holger Freyther 2011-05-01 13:59:41 PDT
Created attachment 91840 [details]
Patch
Comment 2 Adam Barth 2011-05-11 20:47:01 PDT
Comment on attachment 91840 [details]
Patch

That makes a lot of sense.  It's probably a good idea to double-check with Steve Block before landing.
Comment 3 Steve Block 2011-05-12 01:59:33 PDT
Comment on attachment 91840 [details]
Patch

Thanks Adam and Holger. This looks correct to me.

Assuming that Adam's r- was just to give me chance to have a look, r+
Comment 4 Adam Barth 2011-05-12 10:04:34 PDT
> Assuming that Adam's r- was just to give me chance to have a look, r+

It was actually just a mis-click.  :)
Comment 5 Holger Freyther 2011-05-13 08:09:47 PDT
Landed in r86432.