Bug 59809 - [Mac] Scrolling WK2 window should dismiss autocorrection panel.
Summary: [Mac] Scrolling WK2 window should dismiss autocorrection panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Jia Pu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-29 10:40 PDT by Jia Pu
Modified: 2011-04-29 17:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (v1) (1.44 KB, patch)
2011-04-29 10:48 PDT, Jia Pu
no flags Details | Formatted Diff | Diff
Patch (v2) (1.40 KB, patch)
2011-04-29 11:16 PDT, Jia Pu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia Pu 2011-04-29 10:40:03 PDT
Otherwise, the panel becomes detached from the insertion point.

<rdar://problem/9317410>
Comment 1 Jia Pu 2011-04-29 10:48:38 PDT
Created attachment 91700 [details]
Patch (v1)
Comment 2 Sam Weinig 2011-04-29 10:54:56 PDT
Comment on attachment 91700 [details]
Patch (v1)

I led you astray, a better place to do this is in WebPageProxy::pageDidScroll().
Comment 3 Jia Pu 2011-04-29 11:16:32 PDT
Created attachment 91706 [details]
Patch (v2)
Comment 4 WebKit Review Bot 2011-04-29 11:27:15 PDT
Comment on attachment 91706 [details]
Patch (v2)

Rejecting attachment 91706 [details] from commit-queue.

jpu@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Commit Bot 2011-04-29 17:00:16 PDT
Comment on attachment 91706 [details]
Patch (v2)

Clearing flags on attachment: 91706

Committed r85371: <http://trac.webkit.org/changeset/85371>
Comment 6 WebKit Commit Bot 2011-04-29 17:00:21 PDT
All reviewed patches have been landed.  Closing bug.