Bug 5980 - Bidi properties of an inline container whose first child is an inline container are ignored
Summary: Bidi properties of an inline container whose first child is an inline contain...
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-06 11:42 PST by mitz
Modified: 2005-12-19 23:21 PST (History)
0 users

See Also:


Attachments
testcase (592 bytes, text/html)
2005-12-06 11:43 PST, mitz
no flags Details
Adjust embedding at inline containers' boundaries instead of inside (13.72 KB, patch)
2005-12-07 07:38 PST, mitz
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-12-06 11:42:23 PST
Summary: Embedding levels aren't adjusted according to the direction and unicode-bidi properties of an 
inline container if its first child is an inline container. Similarly, embedding levels aren't reset after an 
inline container whose last child is an inline container -- in both cases, bidiNext() doesn't call embed().

To reproduce: open the attached testcase in Safari.

Expected: all lines to read "ABCDEFGHI" (some letters may appear in italics. Firefox renders as expected.

Actual: the letters are in the wrong order on the 2nd, 3rd and 5th lines.
Comment 1 mitz 2005-12-06 11:43:42 PST
Created attachment 4983 [details]
testcase
Comment 2 mitz 2005-12-07 07:38:21 PST
Created attachment 4989 [details]
Adjust embedding at inline containers' boundaries instead of inside
Comment 3 Dave Hyatt 2005-12-07 14:52:17 PST
Comment on attachment 4989 [details]
Adjust embedding at inline containers' boundaries instead of inside

r=me. I even understood it!