Bug 59768 - gpu canvas alpha tests failing on the chromium canaries
Summary: gpu canvas alpha tests failing on the chromium canaries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 18:46 PDT by Dirk Pranke
Modified: 2011-05-20 17:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2011-05-20 14:50 PDT, scroggo
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2011-05-20 15:01 PDT, scroggo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 scroggo 2011-05-11 09:14:11 PDT
Recent changes to skia (not yet in chromium) fix these.
Comment 2 scroggo 2011-05-20 14:50:01 PDT
Created attachment 94274 [details]
Patch
Comment 3 Kenneth Russell 2011-05-20 14:56:40 PDT
Comment on attachment 94274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94274&action=review

> LayoutTests/ChangeLog:5
> +        Remove tests which are now passing from test_expectations.

In general please put the bug's synopsis alongside the link. Comments should go in another paragraph.
Comment 4 scroggo 2011-05-20 15:01:58 PDT
Created attachment 94275 [details]
Patch
Comment 5 scroggo 2011-05-20 15:07:59 PDT
Comment on attachment 94275 [details]
Patch

Added the bug synopsis
Comment 6 WebKit Review Bot 2011-05-20 15:08:51 PDT
Comment on attachment 94275 [details]
Patch

Rejecting attachment 94275 [details] from review queue.

scroggo@google.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 7 WebKit Commit Bot 2011-05-20 17:20:58 PDT
Comment on attachment 94275 [details]
Patch

Clearing flags on attachment: 94275

Committed r87002: <http://trac.webkit.org/changeset/87002>
Comment 8 WebKit Commit Bot 2011-05-20 17:21:03 PDT
All reviewed patches have been landed.  Closing bug.