Bug 59758 - Fix static analyzer warnings for missing assignment to 'self' in -init methods
Summary: Fix static analyzer warnings for missing assignment to 'self' in -init methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 16:19 PDT by David Kilzer (:ddkilzer)
Modified: 2011-04-28 21:58 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.53 KB, patch)
2011-04-28 16:19 PDT, David Kilzer (:ddkilzer) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-04-28 16:19:20 PDT 
Created attachment 91584 [details]
Patch

Reviewed by NOBODY (OOPS!).

* History/WebHistory.mm:
(-[WebHistoryPrivate init]):
* Misc/WebElementDictionary.mm:
(-[WebElementDictionary initWithHitTestResult:]):
* Misc/WebIconDatabase.mm:
(-[WebIconDatabase init]):
* Plugins/WebPluginController.mm:
(-[WebPluginController initWithDocumentView:]):
* Plugins/WebPluginRequest.m:
(-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
* WebCoreSupport/WebEditorClient.mm:
(-[WebEditCommand initWithEditCommand:]):
* WebCoreSupport/WebJavaScriptTextInputPanel.m:
(-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
* WebView/WebNavigationData.mm:
(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
---
 9 files changed, 46 insertions(+), 7 deletions(-)
Comment 1 WebKit Review Bot 2011-04-28 16:22:11 PDT 
Attachment 91584 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Anders Carlsson 2011-04-28 16:38:48 PDT 
Comment on attachment 91584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91584&action=review

> Source/WebKit/mac/ChangeLog:3
> +        <http://webkit.org/b/00000> Fix static analyzer warnings for missing assignment to 'self' in -init methods

This should be a valid bug number of course :)
Comment 3 David Kilzer (:ddkilzer) 2011-04-28 21:58:48 PDT 
Committed r85302: <http://trac.webkit.org/changeset/85302>