Bug 59615 - Fix strict OwnPtr issues seen in about 30 more files
Summary: Fix strict OwnPtr issues seen in about 30 more files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 09:12 PDT by Darin Adler
Modified: 2011-04-27 16:08 PDT (History)
1 user (show)

See Also:


Attachments
Patch (28.66 KB, patch)
2011-04-27 09:16 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (25.82 KB, patch)
2011-04-27 09:25 PDT, Darin Adler
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-04-27 09:12:49 PDT
Fix strict OwnPtr issues seen in about 30 more files
Comment 1 Darin Adler 2011-04-27 09:16:37 PDT
Created attachment 91297 [details]
Patch
Comment 2 Darin Adler 2011-04-27 09:17:33 PDT
I steered away from any tricky cases.
Comment 3 Darin Adler 2011-04-27 09:23:10 PDT
Comment on attachment 91297 [details]
Patch

Patch doesn't apply. Need to rebase.
Comment 4 Darin Adler 2011-04-27 09:25:29 PDT
Created attachment 91299 [details]
Patch
Comment 5 Adam Barth 2011-04-27 13:02:58 PDT
Would you like me to land this patch for you?
Comment 6 Darin Adler 2011-04-27 13:09:54 PDT
(In reply to comment #5)
> Would you like me to land this patch for you?

Hmm, just saw that comment after seeing commit-queue+, but then I realized that I have a free moment here and can probably land it myself. Give me a moment to do that.
Comment 7 Darin Adler 2011-04-27 13:10:04 PDT
setting, not seeing
Comment 8 Darin Adler 2011-04-27 13:27:56 PDT
(In reply to comment #5)
> Would you like me to land this patch for you?

Strike my previous reply. I do not have time to land this right now.

Yes, I would love it if you’d land the patch. Feel free to do so!
Comment 9 Adam Barth 2011-04-27 14:25:29 PDT
Committed r85094: <http://trac.webkit.org/changeset/85094>
Comment 10 David Levin 2011-04-27 16:08:52 PDT
Comment on attachment 91299 [details]
Patch

Clearing cq+ since this was landed by Adam.