WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59615
Fix strict OwnPtr issues seen in about 30 more files
https://bugs.webkit.org/show_bug.cgi?id=59615
Summary
Fix strict OwnPtr issues seen in about 30 more files
Darin Adler
Reported
2011-04-27 09:12:49 PDT
Fix strict OwnPtr issues seen in about 30 more files
Attachments
Patch
(28.66 KB, patch)
2011-04-27 09:16 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(25.82 KB, patch)
2011-04-27 09:25 PDT
,
Darin Adler
levin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2011-04-27 09:16:37 PDT
Created
attachment 91297
[details]
Patch
Darin Adler
Comment 2
2011-04-27 09:17:33 PDT
I steered away from any tricky cases.
Darin Adler
Comment 3
2011-04-27 09:23:10 PDT
Comment on
attachment 91297
[details]
Patch Patch doesn't apply. Need to rebase.
Darin Adler
Comment 4
2011-04-27 09:25:29 PDT
Created
attachment 91299
[details]
Patch
Adam Barth
Comment 5
2011-04-27 13:02:58 PDT
Would you like me to land this patch for you?
Darin Adler
Comment 6
2011-04-27 13:09:54 PDT
(In reply to
comment #5
)
> Would you like me to land this patch for you?
Hmm, just saw that comment after seeing commit-queue+, but then I realized that I have a free moment here and can probably land it myself. Give me a moment to do that.
Darin Adler
Comment 7
2011-04-27 13:10:04 PDT
setting, not seeing
Darin Adler
Comment 8
2011-04-27 13:27:56 PDT
(In reply to
comment #5
)
> Would you like me to land this patch for you?
Strike my previous reply. I do not have time to land this right now. Yes, I would love it if you’d land the patch. Feel free to do so!
Adam Barth
Comment 9
2011-04-27 14:25:29 PDT
Committed
r85094
: <
http://trac.webkit.org/changeset/85094
>
David Levin
Comment 10
2011-04-27 16:08:52 PDT
Comment on
attachment 91299
[details]
Patch Clearing cq+ since this was landed by Adam.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug