Bug 59559 - Fix incorrect use of OwnPtr<T*> in GCActivityCallback
Summary: Fix incorrect use of OwnPtr<T*> in GCActivityCallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks: 59470
  Show dependency tree / graph
 
Reported: 2011-04-26 16:47 PDT by Adrienne Walker
Modified: 2011-04-26 18:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2011-04-26 16:47 PDT, Adrienne Walker 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-04-26 16:47:07 PDT 
Fix incorrect use of OwnPtr<T*> in GCActivityCallback
Comment 1 Adrienne Walker 2011-04-26 16:47:27 PDT 
Created attachment 91180 [details]
Patch
Comment 2 Geoffrey Garen 2011-04-26 16:57:07 PDT 
Comment on attachment 91180 [details]
Patch

r=me
Comment 3 Adrienne Walker 2011-04-26 17:06:56 PDT 
Committed r84986: <http://trac.webkit.org/changeset/84986>
Comment 4 WebKit Review Bot 2011-04-26 18:08:17 PDT 
http://trac.webkit.org/changeset/84986 might have broken Windows 7 Release (Tests)
The following tests are not passing:
fast/blockflow/Kusa-Makura-background-canvas.html
fast/blockflow/border-vertical-lr.html
fast/blockflow/fallback-orientation.html
fast/blockflow/japanese-lr-selection.html
fast/blockflow/japanese-lr-text.html
fast/blockflow/japanese-rl-selection.html
fast/blockflow/japanese-rl-text.html
fast/blockflow/japanese-ruby-vertical-lr.html
fast/blockflow/japanese-ruby-vertical-rl.html
fast/dynamic/text-combine.html
fast/repaint/japanese-rl-selection-clear.html
fast/repaint/japanese-rl-selection-repaint.html
fast/ruby/base-shorter-than-text.html
fast/text/emphasis-vertical.html
fast/text/international/text-combine-image-test.html
fast/text/international/vertical-text-glyph-test.html
fast/text/justify-ideograph-vertical.html