Bug 59320 - Web Inspector: introduce InspectorWorkerAgent
Summary: Web Inspector: introduce InspectorWorkerAgent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 58541
  Show dependency treegraph
 
Reported: 2011-04-25 04:33 PDT by Yury Semikhatsky
Modified: 2011-04-25 06:28 PDT (History)
10 users (show)

See Also:


Attachments
Patch (37.56 KB, patch)
2011-04-25 06:01 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff
Patch for landing (36.07 KB, patch)
2011-04-25 06:24 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-04-25 04:33:24 PDT
We need an agent that would communicate with workers inside the inspected page and allow connecting to the inspector of the corresponding worker context.
Comment 1 Yury Semikhatsky 2011-04-25 06:01:16 PDT
Created attachment 90914 [details]
Patch
Comment 2 Pavel Feldman 2011-04-25 06:08:43 PDT
Comment on attachment 90914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90914&action=review

> Source/WebCore/inspector/Inspector.json:1683
> +                "name": "dispatchMessageOnWorkerInspector",

Which way is what? sendMessageToWorker

> Source/WebCore/inspector/Inspector.json:1698
> +                "name": "dispatchMessageFromWorker",

dispatchMessageFromWorker

> Source/WebCore/inspector/Inspector.json:1703
> +            },

Please remove trailing coma.
Comment 3 Yury Semikhatsky 2011-04-25 06:24:06 PDT
Created attachment 90915 [details]
Patch for landing
Comment 4 Yury Semikhatsky 2011-04-25 06:24:33 PDT
(In reply to comment #2)
> (From update of attachment 90914 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90914&action=review
> 
> > Source/WebCore/inspector/Inspector.json:1683
> > +                "name": "dispatchMessageOnWorkerInspector",
> 
> Which way is what? sendMessageToWorker
>
Done.
 
> > Source/WebCore/inspector/Inspector.json:1698
> > +                "name": "dispatchMessageFromWorker",
> 
> dispatchMessageFromWorker
> 
Done.

> > Source/WebCore/inspector/Inspector.json:1703
> > +            },
> 
> Please remove trailing coma.
Done.
Comment 5 Yury Semikhatsky 2011-04-25 06:28:17 PDT
Committed r84773: <http://trac.webkit.org/changeset/84773>