Bug 58791 - REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r84039
Summary: REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r8...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 09:05 PDT by Hajime Morrita
Modified: 2011-04-18 12:20 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2011-04-18 09:29 PDT, Hajime Morrita
eric: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Hajime Morrita 2011-04-18 09:29:29 PDT
Created attachment 90044 [details]
Patch
Comment 2 John Knottenbelt 2011-04-18 09:32:59 PDT
LGTM
Comment 3 Eric Seidel (no email) 2011-04-18 09:39:02 PDT
Comment on attachment 90044 [details]
Patch

I take it the chromium is the only port with <details> enabled?
Comment 4 Hajime Morrita 2011-04-18 09:46:47 PDT
> (From update of attachment 90044 [details])
> I take it the chromium is the only port with <details> enabled?
No, there is no ifdefs for <details>.
But the crash is reproduced only there.
Comment 5 Hajime Morrita 2011-04-18 09:47:40 PDT
Anyway, thank you for reviewing Eric!
I'm landing this.
Comment 6 Hajime Morrita 2011-04-18 09:49:11 PDT
Committed r84152: <http://trac.webkit.org/changeset/84152>
Comment 7 WebKit Review Bot 2011-04-18 12:20:55 PDT
http://trac.webkit.org/changeset/84152 might have broken GTK Linux 32-bit Debug