Bug 58733 - Windows should use WebCore localized strings
Summary: Windows should use WebCore localized strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-16 13:37 PDT by Sam Weinig
Modified: 2011-04-17 17:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (55.99 KB, patch)
2011-04-16 13:38 PDT, Sam Weinig
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-16 13:37:06 PDT
Windows should use WebCore localized strings
Comment 1 Sam Weinig 2011-04-16 13:38:51 PDT
Created attachment 89931 [details]
Patch
Comment 2 Build Bot 2011-04-16 14:16:23 PDT
Attachment 89931 [details] did not build on win:
Build output: http://queues.webkit.org/results/8450498
Comment 3 Sam Weinig 2011-04-16 14:19:18 PDT
Committed r84094: <http://trac.webkit.org/changeset/84094>
Comment 4 WebKit Review Bot 2011-04-17 17:22:03 PDT
http://trac.webkit.org/changeset/84094 might have broken Windows XP Debug (Tests)
The following tests are not passing:
dom/html/level2/html/HTMLFrameElement01.html
dom/html/level2/html/HTMLFrameElement02.html
dom/html/level2/html/HTMLFrameElement03.html
dom/html/level2/html/HTMLFrameElement04.html
dom/html/level2/html/HTMLFrameElement05.html
dom/html/level2/html/HTMLFrameElement06.html
dom/html/level2/html/HTMLFrameElement07.html
dom/html/level2/html/HTMLFrameElement08.html
dom/html/level2/html/HTMLFrameElement09.html
dom/html/level2/html/HTMLFrameSetElement01.html
dom/html/level2/html/HTMLFrameSetElement02.html
dom/html/level2/html/HTMLIFrameElement01.html
dom/html/level2/html/HTMLIFrameElement02.html
dom/html/level2/html/HTMLIFrameElement03.html
dom/html/level2/html/HTMLIFrameElement04.html
dom/html/level2/html/HTMLIFrameElement05.html
dom/html/level2/html/HTMLIFrameElement06.html
dom/html/level2/html/HTMLIFrameElement07.html
dom/html/level2/html/HTMLIFrameElement08.html
dom/html/level2/html/HTMLIFrameElement09.html