Bug 58694 - Add the ability for PageOverlays to fade in and out
Summary: Add the ability for PageOverlays to fade in and out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 14:21 PDT by Anders Carlsson
Modified: 2011-04-15 18:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.23 KB, patch)
2011-04-15 14:28 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-04-15 14:21:23 PDT 
Add the ability for PageOverlays to fade in and out
Comment 1 Anders Carlsson 2011-04-15 14:28:34 PDT 
Created attachment 89854 [details]
Patch
Comment 2 Sam Weinig 2011-04-15 14:30:06 PDT 
Comment on attachment 89854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89854&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:735
> +void WebPage::uninstallPageOverlay(PageOverlay* pageOverlay, bool fadeOut)

I think this would read better as an enum.
Comment 3 Anders Carlsson 2011-04-15 14:36:18 PDT 
Committed r84034: <http://trac.webkit.org/changeset/84034>
Comment 4 WebKit Review Bot 2011-04-15 18:20:39 PDT 
http://trac.webkit.org/changeset/84034 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/html/details-add-summary-1-and-click.html
fast/html/details-add-summary-1.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-add-summary-10.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-2.html
fast/html/details-add-summary-3-and-click.html
fast/html/details-add-summary-3.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-add-summary-4.html
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-5.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-6.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-add-summary-7.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-8.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-add-summary-9.html
fast/html/details-no-summary1.html
fast/html/details-no-summary2.html
fast/html/details-no-summary3.html
fast/html/details-no-summary4.html
fast/html/details-open-javascript.html
fast/html/details-open1.html
fast/html/details-open2.html
fast/html/details-open3.html
fast/html/details-open4.html
fast/html/details-open5.html
fast/html/details-open6.html
fast/html/details-position.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-remove-summary-1.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-remove-summary-2.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-remove-summary-3.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-4.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-5.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-remove-summary-6.html
fast/html/details-writing-mode.html