RESOLVED FIXED Bug 58694
Add the ability for PageOverlays to fade in and out 
https://bugs.webkit.org/show_bug.cgi?id=58694
Summary Add the ability for PageOverlays to fade in and out
Anders Carlsson
Reported 2011-04-15 14:21:23 PDT
Add the ability for PageOverlays to fade in and out
Attachments
Patch (9.23 KB, patch)
2011-04-15 14:28 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-04-15 14:28:34 PDT
Created attachment 89854 [details] Patch
Sam Weinig
Comment 2 2011-04-15 14:30:06 PDT
Comment on attachment 89854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89854&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:735 > +void WebPage::uninstallPageOverlay(PageOverlay* pageOverlay, bool fadeOut) I think this would read better as an enum.
Anders Carlsson
Comment 3 2011-04-15 14:36:18 PDT
Committed r84034: <http://trac.webkit.org/changeset/84034>
WebKit Review Bot
Comment 4 2011-04-15 18:20:39 PDT
http://trac.webkit.org/changeset/84034 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-1.html fast/html/details-add-summary-10-and-click.html fast/html/details-add-summary-10.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-2.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-3.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-4.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-5.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-6.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-7.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-8.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-9.html fast/html/details-no-summary1.html fast/html/details-no-summary2.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-open-javascript.html fast/html/details-open1.html fast/html/details-open2.html fast/html/details-open3.html fast/html/details-open4.html fast/html/details-open5.html fast/html/details-open6.html fast/html/details-position.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-1.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-2.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-3.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-4.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-5.html fast/html/details-remove-summary-6-and-click.html fast/html/details-remove-summary-6.html fast/html/details-writing-mode.html
Note You need to log in before you can comment on or make changes to this bug.