The commit-queue uses --no-new-test-results to avoid having run-webkit-test drop junk files in its working copy. However, that option appears to be missing from NRWT, blocking our use of it for the commit-queue. Of somewhat lesser importance, NRWT also seems to be missing --wait-for-httpd, but I don't think we actually need that option anymore.
Why don't we need --wait-for-httpd? That moves all the httpd tests to the end and uses locking.
(In reply to comment #1) > Why don't we need --wait-for-httpd? That moves all the httpd tests to the end and uses locking. My understanding is that we only need that if we're going to run two instances of the tests on the same box. I don't think we have any plans to do that in the near future.
(In reply to comment #0) > The commit-queue uses --no-new-test-results to avoid having run-webkit-test drop junk files in its working copy. However, that option appears to be missing from NRWT, blocking our use of it for the commit-queue. > NRWT doesn't generate new tests results unless asked to do so, so maybe this is not necessary? Alternatively, maybe NRWT should be generating new test results by default to match ORWT, and then add this? > Of somewhat lesser importance, NRWT also seems to be missing --wait-for-httpd, but I don't think we actually need that option anymore. NRWT locks all the time, by default.
I'm pretty sure we flipped this default. Yup, I see it in --help now: --no-new-test-results Don't create new baselines when no expected results exist