Bug 58351 - Review tool should work well on iPad
Summary: Review tool should work well on iPad
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 11:12 PDT by Adam Barth
Modified: 2011-04-12 13:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2011-04-12 11:14 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-04-12 11:12:11 PDT 
Review tool should work well on iPad
Comment 1 Adam Barth 2011-04-12 11:14:17 PDT 
Created attachment 89230 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-12 11:15:10 PDT 
Comment on attachment 89230 [details]
Patch

Amen!  Android has this same trouble too.
Comment 3 Adam Barth 2011-04-12 11:16:20 PDT 
> Amen!  Android has this same trouble too.

fishd tells me this bug is fixed on Android, but I haven't tested it.
Comment 4 Eric Seidel (no email) 2011-04-12 11:17:27 PDT 
So I just have to wait for my honeycomb or whatever?  The browser on my Nexus S always displays the bar in a random place. :)
Comment 5 WebKit Commit Bot 2011-04-12 11:41:09 PDT 
Comment on attachment 89230 [details]
Patch

Clearing flags on attachment: 89230

Committed r83616: <http://trac.webkit.org/changeset/83616>
Comment 6 WebKit Commit Bot 2011-04-12 11:41:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Adam Barth 2011-04-12 13:55:37 PDT 
(In reply to comment #4)
> So I just have to wait for my honeycomb or whatever?  The browser on my Nexus S always displays the bar in a random place. :)

That's why I'd rather do a feature detect than a UA detect.  Maybe Ojan knows how to properly feature detect the strange fixed position / scrolling interaction on iOS?