Bug 58099 - change chromium mac gpu reference baselines from leopard to snow leopard
Summary: change chromium mac gpu reference baselines from leopard to snow leopard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 16:54 PDT by Dirk Pranke
Modified: 2011-04-08 15:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2011-04-07 16:57 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2011-04-07 16:59 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2011-04-08 12:52 PDT, Vincent Scheib
eric: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-04-07 16:54:14 PDT
change chromium mac gpu reference baselines from leopard to snow leopard.
Comment 1 Dirk Pranke 2011-04-07 16:57:06 PDT
Created attachment 88735 [details]
Patch
Comment 2 Dirk Pranke 2011-04-07 16:59:53 PDT
Created attachment 88737 [details]
Patch
Comment 3 WebKit Commit Bot 2011-04-07 21:32:36 PDT
Comment on attachment 88737 [details]
Patch

Clearing flags on attachment: 88737

Committed r83250: <http://trac.webkit.org/changeset/83250>
Comment 4 WebKit Commit Bot 2011-04-07 21:32:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Vincent Scheib 2011-04-08 12:52:58 PDT
Created attachment 88860 [details]
Patch
Comment 6 Eric Seidel (no email) 2011-04-08 12:58:34 PDT
Comment on attachment 88860 [details]
Patch

SGTM.
Comment 7 Eric Seidel (no email) 2011-04-08 12:58:58 PDT
Unless you re-open the bug, the commit-queue will not be able to land this patch (it ignores closed bugs).
Comment 8 Dirk Pranke 2011-04-08 13:30:19 PDT
I would probably change the changelog in vincent's patch to something like "add chromium-gpu-linux-x86_64 to the recognized list of ports", since this patch has nothing to do with leopard/snowleopard.
Comment 9 Dirk Pranke 2011-04-08 13:30:38 PDT
otherwise, looks fine.
Comment 10 Vincent Scheib 2011-04-08 15:16:12 PDT
Committed r83346: <http://trac.webkit.org/changeset/83346>