WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58099
change chromium mac gpu reference baselines from leopard to snow leopard
https://bugs.webkit.org/show_bug.cgi?id=58099
Summary
change chromium mac gpu reference baselines from leopard to snow leopard
Dirk Pranke
Reported
2011-04-07 16:54:14 PDT
change chromium mac gpu reference baselines from leopard to snow leopard.
Attachments
Patch
(1.36 KB, patch)
2011-04-07 16:57 PDT
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
Patch
(1.42 KB, patch)
2011-04-07 16:59 PDT
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
Patch
(1.57 KB, patch)
2011-04-08 12:52 PDT
,
Vincent Scheib
eric
: review+
eric
: commit-queue+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-04-07 16:57:06 PDT
Created
attachment 88735
[details]
Patch
Dirk Pranke
Comment 2
2011-04-07 16:59:53 PDT
Created
attachment 88737
[details]
Patch
WebKit Commit Bot
Comment 3
2011-04-07 21:32:36 PDT
Comment on
attachment 88737
[details]
Patch Clearing flags on attachment: 88737 Committed
r83250
: <
http://trac.webkit.org/changeset/83250
>
WebKit Commit Bot
Comment 4
2011-04-07 21:32:42 PDT
All reviewed patches have been landed. Closing bug.
Vincent Scheib
Comment 5
2011-04-08 12:52:58 PDT
Created
attachment 88860
[details]
Patch
Eric Seidel (no email)
Comment 6
2011-04-08 12:58:34 PDT
Comment on
attachment 88860
[details]
Patch SGTM.
Eric Seidel (no email)
Comment 7
2011-04-08 12:58:58 PDT
Unless you re-open the bug, the commit-queue will not be able to land this patch (it ignores closed bugs).
Dirk Pranke
Comment 8
2011-04-08 13:30:19 PDT
I would probably change the changelog in vincent's patch to something like "add chromium-gpu-linux-x86_64 to the recognized list of ports", since this patch has nothing to do with leopard/snowleopard.
Dirk Pranke
Comment 9
2011-04-08 13:30:38 PDT
otherwise, looks fine.
Vincent Scheib
Comment 10
2011-04-08 15:16:12 PDT
Committed
r83346
: <
http://trac.webkit.org/changeset/83346
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug