Bug 57952 - ClipboardWin has unused variables "ExceptionCode ec"
Summary: ClipboardWin has unused variables "ExceptionCode ec"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P5 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 08:27 PDT by Benjamin Poulain
Modified: 2011-04-06 10:19 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.15 KB, patch)
2011-04-06 08:29 PDT, Benjamin Poulain 		kling: review-
Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2011-04-06 08:35 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2011-04-06 08:36 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-04-06 08:27:47 PDT 
While lookint at 19385 I noticed ExceptionCode ec = 0; is never used in the function...
Comment 1 Benjamin Poulain 2011-04-06 08:29:21 PDT 
Created attachment 88430 [details]
Patch
Comment 2 Andreas Kling 2011-04-06 08:32:03 PDT 
Comment on attachment 88430 [details]
Patch

There are more functions in that file doing this. :3
Comment 3 Benjamin Poulain 2011-04-06 08:35:53 PDT 
Created attachment 88431 [details]
Patch
Comment 4 Benjamin Poulain 2011-04-06 08:36:46 PDT 
Created attachment 88432 [details]
Patch

Better with a changelog :)
Comment 5 WebKit Commit Bot 2011-04-06 10:16:49 PDT 
The commit-queue encountered the following flaky tests while processing attachment 88432 [details]:

http/tests/loading/basic-credentials-sent-automatically.html bug 57961 (author: beidson@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-04-06 10:19:50 PDT 
Comment on attachment 88432 [details]
Patch

Clearing flags on attachment: 88432

Committed r83067: <http://trac.webkit.org/changeset/83067>
Comment 7 WebKit Commit Bot 2011-04-06 10:19:54 PDT 
All reviewed patches have been landed.  Closing bug.