Bug 57905 - Move attributedStringFromRange down to WebCore
Summary: Move attributedStringFromRange down to WebCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2011-04-05 16:53 PDT by Alexey Proskuryakov
Modified: 2011-04-05 17:22 PDT (History)
1 user (show)

See Also:

proposed patch (58.33 KB, patch)
2011-04-05 16:58 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-05 16:53:14 PDT
WebCore already has a very similar function, and keeping these in separate projects is extremely confusing. Also, we need this functionality in WK2.
Comment 1 Alexey Proskuryakov 2011-04-05 16:58:59 PDT
Created attachment 88335 [details]
proposed patch
Comment 2 Darin Adler 2011-04-05 17:12:27 PDT
Comment on attachment 88335 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88335&action=review

> Source/WebCore/platform/mac/WebNSAttributedStringExtras.h:2
> + * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.

Should change company name to Apple Inc.
Comment 3 Alexey Proskuryakov 2011-04-05 17:22:37 PDT
Committed <http://trac.webkit.org/changeset/83000>.