Bug 57892 - Don't use Exception.message because it's deprecated
Summary: Don't use Exception.message because it's deprecated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 15:27 PDT by Adam Barth
Modified: 2011-04-05 19:00 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2011-04-05 15:29 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2011-04-05 15:59 PDT, Adam Barth
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-04-05 15:27:08 PDT
Don't use Exception.message because it's deprecated
Comment 1 Adam Barth 2011-04-05 15:29:39 PDT
Created attachment 88320 [details]
Patch
Comment 2 Hajime Morrita 2011-04-05 15:32:04 PDT
lgtm. Could anyone r+ this?
Comment 3 Tony Chang 2011-04-05 15:52:51 PDT
Comment on attachment 88320 [details]
Patch

Is there no way to suppress deprecation warnings?
Comment 5 Adam Barth 2011-04-05 15:55:16 PDT
Mid-air collision detected!  :)
Comment 6 Adam Barth 2011-04-05 15:59:13 PDT
Created attachment 88325 [details]
Patch
Comment 7 Adam Barth 2011-04-05 16:54:39 PDT
Committed r82999: <http://trac.webkit.org/changeset/82999>
Comment 8 WebKit Review Bot 2011-04-05 19:00:54 PDT
http://trac.webkit.org/changeset/82999 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
http/tests/websocket/tests/alert-in-event-handler.html
http/tests/websocket/tests/bad-handshake-crash.html
http/tests/websocket/tests/bufferedAmount-after-close.html
http/tests/websocket/tests/close-on-navigate-new-location.html
http/tests/websocket/tests/close-on-unload-and-force-gc.html
http/tests/websocket/tests/close-on-unload-reference-in-parent.html
http/tests/websocket/tests/close-on-unload.html
http/tests/websocket/tests/cross-origin.html
http/tests/websocket/tests/error-detect.html
http/tests/websocket/tests/frame-length-longer-than-buffer.html
http/tests/websocket/tests/frame-length-overflow.html
http/tests/websocket/tests/frame-length-skip.html
http/tests/websocket/tests/frame-lengths.html
http/tests/websocket/tests/handshake-challenge-randomness.html
http/tests/websocket/tests/handshake-error.html
http/tests/websocket/tests/handshake-fail-by-cross-origin.html
http/tests/websocket/tests/handshake-fail-by-maxlength.html
http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
http/tests/websocket/tests/handshake-fail-by-no-cr.html
http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
http/tests/websocket/tests/handshake-fail-by-prepended-null.html
http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html
http/tests/websocket/tests/httponly-cookie.pl
http/tests/websocket/tests/long-invalid-header.html
http/tests/websocket/tests/multiple-connections.html
http/tests/websocket/tests/null-character.html
http/tests/websocket/tests/reload-crash.html
http/tests/websocket/tests/send-after-close-on-unload.html
http/tests/websocket/tests/send-throw.html
http/tests/websocket/tests/send.html
http/tests/websocket/tests/simple-stress.html
http/tests/websocket/tests/simple.html
http/tests/websocket/tests/sub-protocol-with-space.html
http/tests/websocket/tests/sub-protocol.html
http/tests/websocket/tests/unicode.html
http/tests/websocket/tests/url-no-trailing-slash.html
http/tests/websocket/tests/url-with-credential.html
http/tests/websocket/tests/url-with-empty-query.html
http/tests/websocket/tests/url-with-query-for-no-query.html
http/tests/websocket/tests/url-with-query.html
http/tests/websocket/tests/websocket-pending-activity.html
http/tests/websocket/tests/websocket-protocol-ignored.html
http/tests/websocket/tests/workers/close-in-onmessage-crash.html
http/tests/websocket/tests/workers/close-in-shared-worker.html
http/tests/websocket/tests/workers/close-in-worker.html
http/tests/websocket/tests/workers/shared-worker-simple.html
http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
http/tests/websocket/tests/workers/worker-simple.html