Bug 57659 - Add a ResourceRequestBase::TargetType for favicons
Summary: Add a ResourceRequestBase::TargetType for favicons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-01 14:07 PDT by asanka
Modified: 2011-04-06 14:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2011-04-01 14:42 PDT, asanka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description asanka 2011-04-01 14:07:58 PDT 
Requests for Favicons may require different handling than requests for other types of requests.  I believe having a separate target type for favicons would be sufficient to differentiate these requests.

The immediate application is to suppress prompting for authentication when the target of the request is a favicon.
Comment 1 asanka 2011-04-01 14:42:02 PDT 
Created attachment 87918 [details]
Patch
Comment 2 WebKit Commit Bot 2011-04-06 14:49:28 PDT 
Comment on attachment 87918 [details]
Patch

Clearing flags on attachment: 87918

Committed r83102: <http://trac.webkit.org/changeset/83102>
Comment 3 WebKit Commit Bot 2011-04-06 14:49:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2011-04-06 14:59:30 PDT 
http://trac.webkit.org/changeset/83102 might have broken Windows Release (Build) and Chromium Win Release