Bug 57483 - Chromium Mac crashes when entering fullscreen
Summary: Chromium Mac crashes when entering fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 11:30 PDT by David Dorwin
Modified: 2011-04-04 13:36 PDT (History)
2 users (show)

See Also:

Attachments
Override extraFullScreenStyleSheet in RenderThemeChromiumMac. (3.25 KB, patch)
2011-03-30 11:58 PDT, David Dorwin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Dorwin 2011-03-30 11:30:02 PDT 
The Mac version of Chromium crashes when entering fullscreen because it hits ASSERT_NOT_REACHED in RenderThemeMac::extraFullScreenStyleSheet(), which was added in changeset 82053.

I have a fix.
Comment 1 Jer Noble 2011-03-30 11:42:46 PDT 
David, this may be a dup of bug #57400.
Comment 2 Jer Noble 2011-03-30 11:43:11 PDT 
Oh, disregard.  This is indeed a different issue.
Comment 3 David Dorwin 2011-03-30 11:58:52 PDT 
Created attachment 87591 [details]
Override extraFullScreenStyleSheet in RenderThemeChromiumMac.
Comment 4 Jer Noble 2011-03-30 12:13:06 PDT 
Looks good to me.
Comment 5 WebKit Commit Bot 2011-04-04 13:36:00 PDT 
Comment on attachment 87591 [details]
Override extraFullScreenStyleSheet in RenderThemeChromiumMac.

Clearing flags on attachment: 87591

Committed r82863: <http://trac.webkit.org/changeset/82863>
Comment 6 WebKit Commit Bot 2011-04-04 13:36:04 PDT 
All reviewed patches have been landed.  Closing bug.