RESOLVED FIXED 57323
Rename InlineIterator::nextBreakablePosition to m_nextBreakablePosition to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57323
Summary Rename InlineIterator::nextBreakablePosition to m_nextBreakablePosition to ma...
Eric Seidel (no email)
Reported 2011-03-29 03:02:41 PDT
Rename InlineIterator::nextBreakablePosition to m_nextBreakablePosition to match modern style
Attachments
Patch (9.25 KB, patch)
2011-03-29 03:04 PDT, Eric Seidel (no email)
no flags
Eric Seidel (no email)
Comment 1 2011-03-29 03:04:47 PDT
Ryosuke Niwa
Comment 2 2011-03-29 03:06:29 PDT
Comment on attachment 87289 [details] Patch cq- because of the change log diff.
Eric Seidel (no email)
Comment 3 2011-03-29 03:13:28 PDT
Comment on attachment 87289 [details] Patch The bots are smart enough to fix those types of diffs
WebKit Commit Bot
Comment 4 2011-03-29 06:00:32 PDT
Comment on attachment 87289 [details] Patch Rejecting attachment 87289 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: ith fuzz 2. Hunk #7 succeeded at 1899 with fuzz 2. Hunk #8 succeeded at 1911 with fuzz 2. Hunk #9 succeeded at 1922 with fuzz 2. Hunk #10 succeeded at 1962 with fuzz 2. Hunk #11 succeeded at 2027 with fuzz 2. Hunk #12 succeeded at 2059 with fuzz 2. Hunk #13 succeeded at 2079 with fuzz 2. Hunk #14 succeeded at 2093 with fuzz 2. Hunk #15 succeeded at 2101 with fuzz 2. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8273855
WebKit Commit Bot
Comment 5 2011-03-29 06:45:47 PDT
Comment on attachment 87289 [details] Patch Rejecting attachment 87289 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: at 1 with fuzz 3. patching file Source/WebCore/rendering/InlineIterator.h Hunk #1 succeeded at 37 with fuzz 1. Hunk #2 succeeded at 45 with fuzz 1. Hunk #3 succeeded at 58 with fuzz 1. Hunk #4 FAILED at 188. 1 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/rendering/InlineIterator.h.rej patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8285294
Eric Seidel (no email)
Comment 6 2011-03-29 07:07:56 PDT
Comment on attachment 87289 [details] Patch I think this is next in the chain. :)
WebKit Commit Bot
Comment 7 2011-03-29 07:35:28 PDT
Comment on attachment 87289 [details] Patch Clearing flags on attachment: 87289 Committed r82249: <http://trac.webkit.org/changeset/82249>
WebKit Commit Bot
Comment 8 2011-03-29 07:35:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.