WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
56815
Web Inspector: protocol cleanup. DatabaseAgent.
https://bugs.webkit.org/show_bug.cgi?id=56815
Summary
Web Inspector: protocol cleanup. DatabaseAgent.
Ilya Tikhonovsky
Reported
2011-03-22 02:09:07 PDT
see protocol metabug: - All events should use notification wording, not command wording: addConsoleMessage->consoleMessage, updateConsoleMessageRepeatCount->consoleMessageRepeatCountUpdates, etc. addDatabase was renamed to DatabaseOpened.
Attachments
[patch] initial version
(8.89 KB, patch)
2011-03-22 02:13 PDT
,
Ilya Tikhonovsky
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2011-03-22 02:13:32 PDT
Created
attachment 86445
[details]
[patch] initial version
Yury Semikhatsky
Comment 2
2011-03-22 02:32:53 PDT
Comment on
attachment 86445
[details]
[patch] initial version View in context:
https://bugs.webkit.org/attachment.cgi?id=86445&action=review
> LayoutTests/ChangeLog:10 > + addConsoleMessage->consoleMessage, updateConsoleMessageRepeatCount->consoleMessageRepeatCountUpdates, etc.
The change log describes changes that are not in this CL. Please fix.
Ilya Tikhonovsky
Comment 3
2011-03-22 02:42:40 PDT
Committed
r81651
: <
http://trac.webkit.org/changeset/81651
>
WebKit Review Bot
Comment 4
2011-03-22 03:20:13 PDT
http://trac.webkit.org/changeset/81651
might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: inspector/protocol/database-agent.html
Adam Roben (:aroben)
Comment 5
2011-03-22 05:14:38 PDT
Looks like this new test is failing on many bots.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug