Bug 56731 - new-run-webkit-tests doesn't support sample-on-timeout
Summary: new-run-webkit-tests doesn't support sample-on-timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
: 37402 (view as bug list)
Depends on:
Blocks: 34984
  Show dependency treegraph
 
Reported: 2011-03-20 21:29 PDT by Maciej Stachowiak
Modified: 2012-06-08 15:42 PDT (History)
5 users (show)

See Also:


Attachments
Work in progress (2.80 KB, patch)
2011-06-29 16:36 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (5.37 KB, patch)
2011-06-29 17:08 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2011-03-20 21:29:37 PDT
new-run-webkit-tests doesn't support sample-on-timeout
Comment 1 Adam Barth 2011-06-29 16:36:53 PDT
Created attachment 99180 [details]
Work in progress
Comment 2 Adam Barth 2011-06-29 17:08:10 PDT
Created attachment 99186 [details]
Patch
Comment 3 Eric Seidel (no email) 2011-06-29 17:13:10 PDT
Comment on attachment 99186 [details]
Patch

LGTM!
Comment 4 WebKit Review Bot 2011-06-29 17:41:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 99186 [details]:

http/tests/misc/dns-prefetch-control.html bug 63200 (authors: ap@webkit.org, collinj@webkit.org, and gns@gnome.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Review Bot 2011-06-29 17:42:52 PDT
Comment on attachment 99186 [details]
Patch

Clearing flags on attachment: 99186

Committed r90074: <http://trac.webkit.org/changeset/90074>
Comment 6 WebKit Review Bot 2011-06-29 17:42:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Dirk Pranke 2012-06-08 15:42:37 PDT
*** Bug 37402 has been marked as a duplicate of this bug. ***