56578 – Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard Intel Release (Tests) and SnowLeopard Intel Leaks

RESOLVED FIXED 56578

Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard Intel Release (Tests) and SnowLeopard Intel Leaks

https://bugs.webkit.org/show_bug.cgi?id=56578

Summary Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard I...

Adam Roben (:aroben)

Reported 2011-03-17 11:40:57 PDT

http/tests/inspector/network/network-size.html failed once on Leopard Intel Release (Tests). See the URL for the failure diff.

Attachments
Patch that fixes and re-enables tests. (9.22 KB, patch) 2011-03-21 04:51 PDT, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2011-03-17 11:42:42 PDT

Also failed on SnowLeopard Intel Leaks: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r81363%20(15641)/results.html

Jessie Berlin

Comment 2 2011-03-17 12:16:27 PDT

It has failed at least 3 more times: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r81369%20(27000)/results.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r81372%20(27002)/results.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r81373%20(27003)/results.html

Adam Roben (:aroben)

Comment 3 2011-03-17 13:16:48 PDT

Still failing. http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r81376%20(27006)/http/tests/inspector/network/network-size-pretty-diff.html

Adam Roben (:aroben)

Comment 4 2011-03-17 13:49:18 PDT

Added to the mac Skipped file Committed r81382: <http://trac.webkit.org/changeset/81382>

Adam Roben (:aroben)

Comment 5 2011-03-17 14:41:52 PDT

After skipping network-size.html, network-timing.html started failing: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r81385%20(29911)/http/tests/inspector/network/network-timing-pretty-diff.html Pavel Feldman says we should just skip these tests for now, since they are unreliable.

Adam Roben (:aroben)

Comment 6 2011-03-17 15:04:41 PDT

Disabled the tests Committed r81391: <http://trac.webkit.org/changeset/81391>

Vsevolod Vlasov

Comment 7 2011-03-21 04:51:48 PDT

Created attachment 86307 [details] Patch that fixes and re-enables tests.

Adam Roben (:aroben)

Comment 8 2011-03-21 07:21:27 PDT

Thanks for looking into this, Vsevolod!

WebKit Commit Bot

Comment 9 2011-03-21 12:50:07 PDT

Comment on attachment 86307 [details] Patch that fixes and re-enables tests. Clearing flags on attachment: 86307 Committed r81601: <http://trac.webkit.org/changeset/81601>

WebKit Commit Bot

Comment 10 2011-03-21 12:50:13 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 11 2011-03-21 15:02:05 PDT

http://trac.webkit.org/changeset/81601 might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/inspector/network/network-size.html

Note You need to log in before you can comment on or make changes to this bug.