Bug 56547 - Add a few Objective-C++ files to the WebCore GYP build
Summary: Add a few Objective-C++ files to the WebCore GYP build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-17 00:15 PDT by Adam Barth
Modified: 2011-03-17 01:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2011-03-17 00:15 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-17 00:15:17 PDT
Add a few Objective-C++ files to the WebCore GYP build
Comment 1 Adam Barth 2011-03-17 00:15:59 PDT
Created attachment 86038 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-17 00:16:41 PDT
Comment on attachment 86038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86038&action=review

OK.

> Source/WebCore/gyp/WebCore.gyp:73
>          ['exclude', 'bridge/testbindings\\.cpp$'], # Remove from GYPI?
> +        ['exclude', 'bridge/testbindings\\.mm$'], # Remove from GYPI?

Why not a pattern here?
Comment 3 WebKit Commit Bot 2011-03-17 01:10:47 PDT
Comment on attachment 86038 [details]
Patch

Clearing flags on attachment: 86038

Committed r81337: <http://trac.webkit.org/changeset/81337>
Comment 4 WebKit Commit Bot 2011-03-17 01:10:52 PDT
All reviewed patches have been landed.  Closing bug.