WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
56502
[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
https://bugs.webkit.org/show_bug.cgi?id=56502
Summary
[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFile...
Eric U.
Reported
2011-03-16 16:41:24 PDT
The FileSystem spec has changed: FileEntry.toURI has been renamed to FileEntry.toURL [
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-EntrySync-toURL
] Likewise, resolveLocalFileSystemURI has been renamed to resolveLocalFileSystemURL. We need to update our bindings.
Attachments
Patch
(20.96 KB, patch)
2011-03-17 12:51 PDT
,
Adam Klein
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Klein
Comment 1
2011-03-17 10:13:42 PDT
I'll pick this up in some extra cycles.
Adam Klein
Comment 2
2011-03-17 12:51:05 PDT
Created
attachment 86082
[details]
Patch
Eric U.
Comment 3
2011-03-17 12:53:19 PDT
Comment on
attachment 86082
[details]
Patch LGTM--thanks.
WebKit Commit Bot
Comment 4
2011-03-17 16:56:09 PDT
Comment on
attachment 86082
[details]
Patch Rejecting
attachment 86082
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output:
http://queues.webkit.org/results/8195416
Adam Barth
Comment 5
2011-03-17 17:18:42 PDT
+eric: This commit-queue error could be fall-out from the mechanize upgrade.
WebKit Commit Bot
Comment 6
2011-03-17 20:54:01 PDT
Comment on
attachment 86082
[details]
Patch Clearing flags on attachment: 86082 Committed
r81438
: <
http://trac.webkit.org/changeset/81438
>
WebKit Commit Bot
Comment 7
2011-03-17 20:54:06 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug