Bug 56502 - [filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
Summary: [filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFile...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 16:41 PDT by Eric U.
Modified: 2011-03-17 20:54 PDT (History)
6 users (show)

See Also:


Attachments
Patch (20.96 KB, patch)
2011-03-17 12:51 PDT, Adam Klein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric U. 2011-03-16 16:41:24 PDT
The FileSystem spec has changed:

FileEntry.toURI has been renamed to FileEntry.toURL [http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-EntrySync-toURL]

Likewise, resolveLocalFileSystemURI has been renamed to resolveLocalFileSystemURL.  We need to update our bindings.
Comment 1 Adam Klein 2011-03-17 10:13:42 PDT
I'll pick this up in some extra cycles.
Comment 2 Adam Klein 2011-03-17 12:51:05 PDT
Created attachment 86082 [details]
Patch
Comment 3 Eric U. 2011-03-17 12:53:19 PDT
Comment on attachment 86082 [details]
Patch

LGTM--thanks.
Comment 4 WebKit Commit Bot 2011-03-17 16:56:09 PDT
Comment on attachment 86082 [details]
Patch

Rejecting attachment 86082 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8195416
Comment 5 Adam Barth 2011-03-17 17:18:42 PDT
+eric: This commit-queue error could be fall-out from the mechanize upgrade.
Comment 6 WebKit Commit Bot 2011-03-17 20:54:01 PDT
Comment on attachment 86082 [details]
Patch

Clearing flags on attachment: 86082

Committed r81438: <http://trac.webkit.org/changeset/81438>
Comment 7 WebKit Commit Bot 2011-03-17 20:54:06 PDT
All reviewed patches have been landed.  Closing bug.