Bug 56464 - Tiled backing store should only request repaint for updated areas
Summary: Tiled backing store should only request repaint for updated areas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45423
  Show dependency treegraph
 
Reported: 2011-03-16 08:24 PDT by Gustavo Noronha (kov)
Modified: 2011-04-13 02:01 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.11 KB, patch)
2011-03-16 08:37 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2011-03-16 08:24:35 PDT
Subject says it all. Currently the tiled backing store code has this FIXME:

// FIXME: should not request system repaint for the full tile.
Comment 1 Gustavo Noronha (kov) 2011-03-16 08:37:38 PDT
Created attachment 85932 [details]
Patch
Comment 2 Andreas Kling 2011-03-16 19:59:28 PDT
Comment on attachment 85932 [details]
Patch

Oh, awesome! r=me
Comment 3 Gustavo Noronha (kov) 2011-03-17 05:00:44 PDT
Comment on attachment 85932 [details]
Patch

Clearing flags on attachment: 85932

Committed r81347: <http://trac.webkit.org/changeset/81347>
Comment 4 Gustavo Noronha (kov) 2011-03-17 05:00:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Kenneth Rohde Christiansen 2011-03-17 05:27:35 PDT
Comment on attachment 85932 [details]
Patch

Are we doing this for our webkit2 tiling?
Comment 6 WebKit Review Bot 2011-03-17 05:59:51 PDT
http://trac.webkit.org/changeset/81347 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
svg/custom/clip-path-referencing-use2.svg