Bug 56243 - Web Inspector: follow up to error reporting, fixing multiple regressions.
Summary: Web Inspector: follow up to error reporting, fixing multiple regressions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-11 22:58 PST by Pavel Feldman
Modified: 2011-03-12 01:11 PST (History)
10 users (show)

See Also:

Attachments
Patch (28.81 KB, patch)
2011-03-11 23:03 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-03-11 22:58:06 PST 
Patch to follow.
Comment 1 Pavel Feldman 2011-03-11 23:03:38 PST 
Created attachment 85571 [details]
Patch
Comment 2 Ilya Tikhonovsky 2011-03-11 23:10:37 PST 
Comment on attachment 85571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85571&action=review

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:87
> +        if (!injectedScript.setPropertyValue(objectId, propertyName, expression))
> +            *errorString = "Failed setting value.";

please generate the error in js function and propagate it to the top level.
Comment 3 Pavel Feldman 2011-03-12 01:11:02 PST 
Committed r80931: <http://trac.webkit.org/changeset/80931>