WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
56243
Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243
Summary
Web Inspector: follow up to error reporting, fixing multiple regressions.
Pavel Feldman
Reported
2011-03-11 22:58:06 PST
Patch to follow.
Attachments
Patch
(28.81 KB, patch)
2011-03-11 23:03 PST
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2011-03-11 23:03:38 PST
Created
attachment 85571
[details]
Patch
Ilya Tikhonovsky
Comment 2
2011-03-11 23:10:37 PST
Comment on
attachment 85571
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=85571&action=review
> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:87 > + if (!injectedScript.setPropertyValue(objectId, propertyName, expression)) > + *errorString = "Failed setting value.";
please generate the error in js function and propagate it to the top level.
Pavel Feldman
Comment 3
2011-03-12 01:11:02 PST
Committed
r80931
: <
http://trac.webkit.org/changeset/80931
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug