Bug 55950 - addInlineStyleIfNeeded should take EditingStyle
Summary: addInlineStyleIfNeeded should take EditingStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 49956
  Show dependency tree / graph
 
Reported: 2011-03-08 11:09 PST by Ryosuke Niwa
Modified: 2011-03-08 12:45 PST (History)
2 users (show)

See Also:

Attachments
cleanup (11.07 KB, patch)
2011-03-08 11:36 PST, Ryosuke Niwa 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-03-08 11:09:15 PST 
This is a cleanup.
Comment 1 Ryosuke Niwa 2011-03-08 11:36:29 PST 
Created attachment 85068 [details]
cleanup
Comment 2 Darin Adler 2011-03-08 11:44:49 PST 
Comment on attachment 85068 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=85068&action=review

> Source/WebCore/editing/ApplyStyleCommand.cpp:79
> -    explicit StyleChange(CSSStyleDeclaration*, const Position&);
> +    explicit StyleChange(EditingStyle*, const Position&);

It doesn’t make any sense to use the explicit keyword on a constructor that can’t be called with a single argument. So “explicit” should be removed here.
Comment 3 Ryosuke Niwa 2011-03-08 11:57:56 PST 
(In reply to comment #2)
> (From update of attachment 85068 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85068&action=review
> 
> > Source/WebCore/editing/ApplyStyleCommand.cpp:79
> > -    explicit StyleChange(CSSStyleDeclaration*, const Position&);
> > +    explicit StyleChange(EditingStyle*, const Position&);
> 
> It doesn’t make any sense to use the explicit keyword on a constructor that can’t be called with a single argument. So “explicit” should be removed here.

That's what I thought.  Okay, I'm getting rid of that.  Thanks for the review.
Comment 4 Ryosuke Niwa 2011-03-08 12:45:50 PST 
Landed as http://trac.webkit.org/changeset/80580.