Bug 55885 - [chromium] Undefined default skia parameter in ShaderChromium.h
Summary: [chromium] Undefined default skia parameter in ShaderChromium.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-07 10:52 PST by Adrienne Walker
Modified: 2011-03-07 14:34 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2011-03-07 11:16 PST, Adrienne Walker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-03-07 10:52:19 PST
From an email from Grace: http://trac.webkit.org/changeset/79043 moved SK_B32_SHIFT test from ContentLayerChromium.cpp to ShaderChromium.h. But it didn't move "#include "SkcolorPriv.h"" where the default value is defined.
Comment 1 Adrienne Walker 2011-03-07 11:16:55 PST
Created attachment 84960 [details]
Patch
Comment 2 James Robinson 2011-03-07 11:18:34 PST
Comment on attachment 84960 [details]
Patch

R=me
Comment 3 WebKit Commit Bot 2011-03-07 14:34:27 PST
Comment on attachment 84960 [details]
Patch

Clearing flags on attachment: 84960

Committed r80499: <http://trac.webkit.org/changeset/80499>
Comment 4 WebKit Commit Bot 2011-03-07 14:34:32 PST
All reviewed patches have been landed.  Closing bug.