WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55690
Web Inspector: install onerror handler in inspector tests
https://bugs.webkit.org/show_bug.cgi?id=55690
Summary
Web Inspector: install onerror handler in inspector tests
Andrey Kosyakov
Reported
2011-03-03 11:18:23 PST
Currently, web inspector console is not captured in test output. We redefine console.log & co in inspector test suites to direct the messages to test output, yet if an exception happens in front-end during test, we do not capture the exception information. This patch adds onerror handler that will post error information to test output.
Attachments
patch
(2.02 KB, patch)
2011-03-03 11:24 PST
,
Andrey Kosyakov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1
2011-03-03 11:24:08 PST
Created
attachment 84597
[details]
patch
WebKit Commit Bot
Comment 2
2011-03-04 14:24:46 PST
Comment on
attachment 84597
[details]
patch Rejecting
attachment 84597
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: ed 3 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/http/tests/inspector/inspector-test.js Hunk #1 FAILED at 74. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/tests/inspector/inspector-test.js.rej patching file LayoutTests/http/tests/inspector/resources/extension-main.js Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Pavel Feldman', u'--fo..." exit_code: 1 Full output:
http://queues.webkit.org/results/8038025
Andrey Kosyakov
Comment 3
2011-03-10 06:47:57 PST
Manually committed
r80417
:
http://trac.webkit.org/changeset/80417
Andrey Kosyakov
Comment 4
2011-03-10 06:49:11 PST
Comment on
attachment 84597
[details]
patch Removing pfeldman's r+ from obsolete patch.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug