Bug 55690 - Web Inspector: install onerror handler in inspector tests
Summary: Web Inspector: install onerror handler in inspector tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
Depends on:
Reported: 2011-03-03 11:18 PST by Andrey Kosyakov
Modified: 2011-03-10 06:49 PST (History)
11 users (show)

See Also:

patch (2.02 KB, patch)
2011-03-03 11:24 PST, Andrey Kosyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-03-03 11:18:23 PST
Currently, web inspector console is not captured in test output. We redefine console.log & co in inspector test suites to direct the messages to test output, yet if an exception happens in front-end during test, we do not capture the exception information.
This patch adds onerror handler that will post error information to test output.
Comment 1 Andrey Kosyakov 2011-03-03 11:24:08 PST
Created attachment 84597 [details]
Comment 2 WebKit Commit Bot 2011-03-04 14:24:46 PST
Comment on attachment 84597 [details]

Rejecting attachment 84597 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
ed 3 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/http/tests/inspector/inspector-test.js
Hunk #1 FAILED at 74.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/tests/inspector/inspector-test.js.rej
patching file LayoutTests/http/tests/inspector/resources/extension-main.js

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Pavel Feldman', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/8038025
Comment 3 Andrey Kosyakov 2011-03-10 06:47:57 PST
Manually committed r80417: http://trac.webkit.org/changeset/80417
Comment 4 Andrey Kosyakov 2011-03-10 06:49:11 PST
Comment on attachment 84597 [details]

Removing pfeldman's r+ from obsolete patch.