Bug 55532 - Teach JavaScriptCore GYP build about private headers
Summary: Teach JavaScriptCore GYP build about private headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-01 17:04 PST by Adam Barth
Modified: 2011-03-03 20:30 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2011-03-01 17:05 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-01 17:04:13 PST
Teach JavaScriptCore GYP build about private headers
Comment 1 Adam Barth 2011-03-01 17:05:35 PST
Created attachment 84329 [details]
Patch
Comment 2 Adam Barth 2011-03-01 17:05:51 PST
This patch depends on this GYP patch:

http://codereview.chromium.org/6592088/
Comment 3 Eric Seidel (no email) 2011-03-01 17:08:29 PST
Comment on attachment 84329 [details]
Patch

OK.  I'll let you CQ it if your gyp patch lands.
Comment 4 Adam Barth 2011-03-03 12:38:13 PST
Comment on attachment 84329 [details]
Patch

The GYP change has landed.
Comment 5 WebKit Commit Bot 2011-03-03 20:09:51 PST
Comment on attachment 84329 [details]
Patch

Clearing flags on attachment: 84329

Committed r80312: <http://trac.webkit.org/changeset/80312>
Comment 6 WebKit Commit Bot 2011-03-03 20:09:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2011-03-03 20:30:13 PST
The commit-queue encountered the following flaky tests while processing attachment 84329 [details]:

security/block-test.html bug 55741 (authors: beidson@apple.com, mrowe@apple.com, and sam@webkit.org)
The commit-queue is continuing to process your patch.