Bug 55478 - [Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names
Summary: [Qt][WK2] generate-forwarding-headers.pl should generate paths with framework...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 50251
  Show dependency tree / graph
 
Reported: 2011-03-01 10:13 PST by Andras Becsi
Modified: 2011-03-07 06:17 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (2.91 KB, patch)
2011-03-02 07:09 PST, Andras Becsi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2011-03-01 10:13:29 PST 
On case-insensitive systems the generated forwarding headers case build problems, because of file name clashes.

One such example is:
Source/WebKit2/Platform/Logging.h
and
Source/WebCore/platform/Logging.h

where including (p|P)latform/Logging.h in the final build step is ambiguous on case-insensitive systems, so the generated header should also contain the framework name.
Comment 1 Andras Becsi 2011-03-02 07:09:38 PST 
Created attachment 84414 [details]
proposed patch
Comment 2 Laszlo Gombos 2011-03-02 07:32:13 PST 
Comment on attachment 84414 [details]
proposed patch

Nice, thanks. r+.
Comment 3 WebKit Commit Bot 2011-03-02 08:02:02 PST 
Comment on attachment 84414 [details]
proposed patch

Clearing flags on attachment: 84414

Committed r80131: <http://trac.webkit.org/changeset/80131>
Comment 4 WebKit Commit Bot 2011-03-02 08:02:06 PST 
All reviewed patches have been landed.  Closing bug.