Bug 55275 - Augment style guidelines about meaningless parameters from text the unwritten rules email.
Summary: Augment style guidelines about meaningless parameters from text the unwritten...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks: 55271
  Show dependency treegraph
 
Reported: 2011-02-25 15:57 PST by David Levin
Modified: 2011-04-06 19:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2011-02-25 15:59 PST, David Levin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-02-25 15:57:55 PST
This text is in the email. The guideline is already in the style guide but it could use another example and a little more text (so this patch does that).


*Function parameters*
Don't put in parameter names in function declarations if they don't add
information.  A good rule of thumb is if the parameter type name contains
the parameter name (without trailing numbers or pluralization), then the
parameter name isn't needed.  Usually, there should be a parameter name for
bools, strings, and numerical types.
Comment 1 David Levin 2011-02-25 15:59:41 PST
Created attachment 83895 [details]
Patch
Comment 2 WebKit Commit Bot 2011-04-06 18:04:47 PDT
Comment on attachment 83895 [details]
Patch

Clearing flags on attachment: 83895

Committed r83127: <http://trac.webkit.org/changeset/83127>
Comment 3 WebKit Commit Bot 2011-04-06 18:04:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2011-04-06 19:04:13 PDT
http://trac.webkit.org/changeset/83127 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
fast/dom/52776.html
fast/text/complex-text-opacity.html
fast/text/international/bidi-AN-after-L.html
fast/text/international/bidi-AN-after-empty-run.html
fast/text/international/bidi-CS-after-AN.html
fast/text/international/bidi-mirror-he-ar.html
fast/text/international/bidi-neutral-run.html
platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html