Bug 54998 - [Qt] check webkit style fails in qt/tests
Summary: [Qt] check webkit style fails in qt/tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 14:10 PST by Gopal Raghavan
Modified: 2011-02-23 01:07 PST (History)
1 user (show)

See Also:

Attachments
checker patch to fix style check errors related to qt/tests (1.39 KB, patch)
2011-02-22 14:15 PST, Gopal Raghavan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gopal Raghavan 2011-02-22 14:10:29 PST 
As part of bug 502222, I was getting this error.
-------
failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1

Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:1:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
--
So I added a patch to 50222.
Reviewer suggested to create a separate patch
Comment 1 Gopal Raghavan 2011-02-22 14:15:33 PST 
Created attachment 83386 [details]
checker patch to fix style check errors related to qt/tests
Comment 2 WebKit Commit Bot 2011-02-23 01:07:45 PST 
Comment on attachment 83386 [details]
checker patch to fix style check errors related to qt/tests

Clearing flags on attachment: 83386

Committed r79419: <http://trac.webkit.org/changeset/79419>
Comment 3 WebKit Commit Bot 2011-02-23 01:07:50 PST 
All reviewed patches have been landed.  Closing bug.