Bug 54977 - [Qt] [Symbian] build system fixes
Summary: [Qt] [Symbian] build system fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Siddharth Mathur
URL:
Keywords: Qt
Depends on:
Blocks: 50251
  Show dependency tree / graph
 
Reported: 2011-02-22 11:36 PST by Siddharth Mathur
Modified: 2011-04-04 17:10 PDT (History)
5 users (show)

See Also:

Attachments
fix symbian build break (1.04 KB, patch)
2011-04-04 14:52 PDT, jade han 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Siddharth Mathur 2011-02-22 11:36:12 PST 
- After recent .pro and .pri refactoring, correct the way WebCore static library is linked. Affects Symbian and Windows primarily.  
- Also fix UID3s for WebKit2 on Symbian
Comment 1 Laszlo Gombos 2011-03-07 06:23:50 PST 
Fix for UID3 for WebKit2 for Symbian are landed as http://trac.webkit.org/changeset/79446. Keep the bug open as more fixes are needed.
Comment 2 jade han 2011-04-04 14:52:51 PDT 
Created attachment 88136 [details]
fix symbian build break
Comment 3 Csaba Osztrogonác 2011-04-04 15:24:16 PDT 
Comment on attachment 88136 [details]
fix symbian build break

LGTM, r=me to go ahead. But we usually don't upload independent patches to a same bug report. :S

You don't need to upload to bugzilla this kind of simple buildfixes, just 
ask a reviewer or a committer on #qtwebkit or #webkit to land it manually. ;)
Comment 4 Csaba Osztrogonác 2011-04-04 15:34:14 PDT 
Comment on attachment 88136 [details]
fix symbian build break

Landed in http://trac.webkit.org/changeset/82883
Comment 5 WebKit Review Bot 2011-04-04 17:10:42 PDT 
http://trac.webkit.org/changeset/82883 might have broken Windows XP Debug (Tests)