Bug 54954 – Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 83306 [details]
[PATCH] Proposed change, yet to compile JSC.

[WebKit Review Bot]

Attachment 83306 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorDOMAgent.h:137:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InjectedScriptHost.h:61:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InjectedScriptHost.h:65:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Collabora GTK+ EWS bot]

Attachment 83306 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7949059

[Early Warning System Bot]

Attachment 83306 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7943288

[Build Bot]

Attachment 83306 [details] did not build on win:
Build output: http://queues.webkit.org/results/7948139

[Yury Semikhatsky]

Comment on attachment 83306 [details]
[PATCH] Proposed change, yet to compile JSC.

View in context: https://bugs.webkit.org/attachment.cgi?id=83306&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:-58
> -$typeTransform{"InjectedScript"} = {

Nice.

[WebKit Review Bot]

Attachment 83306 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7940964

[Pavel Feldman]

Committed r79345: <http://trac.webkit.org/changeset/79345>