WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
54954
Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
https://bugs.webkit.org/show_bug.cgi?id=54954
Summary
Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
Pavel Feldman
Reported
2011-02-22 06:35:13 PST
Patch to follow.
Attachments
[PATCH] Proposed change, yet to compile JSC.
(28.63 KB, patch)
2011-02-22 06:44 PST
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2011-02-22 06:44:23 PST
Created
attachment 83306
[details]
[PATCH] Proposed change, yet to compile JSC.
WebKit Review Bot
Comment 2
2011-02-22 06:47:04 PST
Attachment 83306
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorDOMAgent.h:137: The parameter name "node" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InjectedScriptHost.h:61: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InjectedScriptHost.h:65: The parameter name "node" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Collabora GTK+ EWS bot
Comment 3
2011-02-22 06:54:49 PST
Attachment 83306
[details]
did not build on gtk: Build output:
http://queues.webkit.org/results/7949059
Early Warning System Bot
Comment 4
2011-02-22 06:55:38 PST
Attachment 83306
[details]
did not build on qt: Build output:
http://queues.webkit.org/results/7943288
Build Bot
Comment 5
2011-02-22 06:59:32 PST
Attachment 83306
[details]
did not build on win: Build output:
http://queues.webkit.org/results/7948139
Yury Semikhatsky
Comment 6
2011-02-22 07:20:45 PST
Comment on
attachment 83306
[details]
[PATCH] Proposed change, yet to compile JSC. View in context:
https://bugs.webkit.org/attachment.cgi?id=83306&action=review
> Source/WebCore/inspector/CodeGeneratorInspector.pm:-58 > -$typeTransform{"InjectedScript"} = {
Nice.
WebKit Review Bot
Comment 7
2011-02-22 07:47:20 PST
Attachment 83306
[details]
did not build on mac: Build output:
http://queues.webkit.org/results/7940964
Pavel Feldman
Comment 8
2011-02-22 12:18:36 PST
Committed
r79345
: <
http://trac.webkit.org/changeset/79345
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug