Bug 54909 - canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
Summary: canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 54367
  Show dependency tree / graph
 
Reported: 2011-02-21 14:39 PST by Nico Weber
Modified: 2011-02-21 22:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2011-02-21 14:57 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2011-02-21 17:06 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-02-21 14:39:24 PST 
In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../dom/Node.cpp:72:
In file included from ../rendering/RenderBlock.h:30:
../rendering/RootInlineBox.h:80:10: error: 'WebCore::RootInlineBox::canAccommodateEllipsis' hides overloaded virtual function [-Woverloaded-virtual]
    bool canAccommodateEllipsis(bool ltr, int blockEdge, int lineBoxEdge, int ellipsisWidth);
         ^
In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../dom/Node.cpp:72:
In file included from ../rendering/RenderBlock.h:30:
In file included from ../rendering/RootInlineBox.h:25:
../rendering/InlineFlowBox.h:178:18: note: hidden overloaded virtual function 'WebCore::InlineFlowBox::canAccommodateEllipsis' declared here
    virtual bool canAccommodateEllipsis(bool ltr, int blockEdge, int ellipsisWidth);


This was added in http://trac.webkit.org/changeset/6858 and not touched since. It looks like these functions are not meant to be overrides. One of the two should be renamed.
Comment 1 Nico Weber 2011-02-21 14:57:31 PST 
Created attachment 83220 [details]
Patch
Comment 2 Nico Weber 2011-02-21 17:06:17 PST 
Created attachment 83242 [details]
Patch
Comment 3 WebKit Commit Bot 2011-02-21 21:50:21 PST 
The commit-queue encountered the following flaky tests while processing attachment 83242 [details]:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2011-02-21 21:52:06 PST 
Comment on attachment 83242 [details]
Patch

Clearing flags on attachment: 83242

Committed r79286: <http://trac.webkit.org/changeset/79286>
Comment 5 WebKit Commit Bot 2011-02-21 21:52:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-02-21 22:37:23 PST 
http://trac.webkit.org/changeset/79286 might have broken GTK Linux 32-bit Release