Bug 54909 – canAccommodateEllipsis() confuses clang's -Woverloaded-virtual

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nico Weber]

In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../dom/Node.cpp:72:
In file included from ../rendering/RenderBlock.h:30:
../rendering/RootInlineBox.h:80:10: error: 'WebCore::RootInlineBox::canAccommodateEllipsis' hides overloaded virtual function [-Woverloaded-virtual]
    bool canAccommodateEllipsis(bool ltr, int blockEdge, int lineBoxEdge, int ellipsisWidth);
         ^
In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../dom/Node.cpp:72:
In file included from ../rendering/RenderBlock.h:30:
In file included from ../rendering/RootInlineBox.h:25:
../rendering/InlineFlowBox.h:178:18: note: hidden overloaded virtual function 'WebCore::InlineFlowBox::canAccommodateEllipsis' declared here
    virtual bool canAccommodateEllipsis(bool ltr, int blockEdge, int ellipsisWidth);


This was added in http://trac.webkit.org/changeset/6858 and not touched since. It looks like these functions are not meant to be overrides. One of the two should be renamed.

[Nico Weber]

Created attachment 83220 [details]
Patch

[Nico Weber]

Created attachment 83242 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 83242 [details]:

animations/suspend-resume-animation.html bug 48161 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 83242 [details]
Patch

Clearing flags on attachment: 83242

Committed r79286: <http://trac.webkit.org/changeset/79286>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/79286 might have broken GTK Linux 32-bit Release