Bug 54612 - keyboard support for extending/shrinking comment context
Summary: keyboard support for extending/shrinking comment context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-16 20:15 PST by Ojan Vafai
Modified: 2011-02-20 23:21 PST (History)
1 user (show)

See Also:


Attachments
Patch (7.90 KB, patch)
2011-02-16 20:18 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (7.67 KB, patch)
2011-02-17 20:58 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (8.47 KB, patch)
2011-02-20 19:08 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (6.64 KB, patch)
2011-02-20 22:55 PST, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-02-16 20:15:12 PST
keyboard support for extending/shrinking comment context
Comment 1 Ojan Vafai 2011-02-16 20:18:13 PST
Created attachment 82747 [details]
Patch
Comment 2 Ojan Vafai 2011-02-17 20:58:36 PST
Created attachment 82912 [details]
Patch
Comment 3 Ojan Vafai 2011-02-20 19:08:15 PST
Created attachment 83116 [details]
Patch
Comment 4 Ojan Vafai 2011-02-20 21:58:40 PST
Comment on attachment 83116 [details]
Patch

Removing review flag until bug 54849 is resolved since it will simplify this patch some.
Comment 5 Ojan Vafai 2011-02-20 22:55:53 PST
Created attachment 83130 [details]
Patch
Comment 6 Adam Barth 2011-02-20 23:08:43 PST
Comment on attachment 83130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83130&action=review

Interesting...  You should add this to the help screen.  :)

> Websites/bugs.webkit.org/code-review.js:82
> +    up: 38

Sigh at ie trailing comma bug...
Comment 7 Ojan Vafai 2011-02-20 23:21:52 PST
Committed r79191: <http://trac.webkit.org/changeset/79191>