Bug 54595 - new-run-webkit-tests: --dry-run hangs with --worker-model=processes
Summary: new-run-webkit-tests: --dry-run hangs with --worker-model=processes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-16 15:31 PST by Dirk Pranke
Modified: 2011-02-17 16:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.93 KB, patch)
2011-02-16 15:34 PST, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-16 15:31:12 PST 
new-run-webkit-tests: --dry-run hangs with --worker-model=processes
Comment 1 Dirk Pranke 2011-02-16 15:34:23 PST 
Created attachment 82711 [details]
Patch
Comment 2 Ojan Vafai 2011-02-17 00:01:15 PST 
Comment on attachment 82711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82711&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:122
> +        keyboard_interrupted = False
> +        interrupted = False
> +        thread_timings = []

Nit: I prefer variables being defined as close to the code they're used as possible. So, I'd move these down to be around line 131 instead.
Comment 3 Dirk Pranke 2011-02-17 16:46:54 PST 
Committed r78930: <http://trac.webkit.org/changeset/78930>