WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
54581
[Qt] Enable tiled backing store by default in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=54581
Summary
[Qt] Enable tiled backing store by default in MiniBrowser.
Yael
Reported
2011-02-16 13:36:02 PST
A patch is coming soon.
Attachments
Patch.
(2.34 KB, patch)
2011-02-16 13:40 PST
,
Yael
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yael
Comment 1
2011-02-16 13:40:57 PST
Created
attachment 82685
[details]
Patch. I found a problem in the tiled backing store code, so should land this once that bug is fixed.
Andreas Kling
Comment 2
2011-02-16 13:42:56 PST
Comment on
attachment 82685
[details]
Patch. r=me
WebKit Commit Bot
Comment 3
2011-02-16 19:00:33 PST
Comment on
attachment 82685
[details]
Patch. Rejecting
attachment 82685
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 Last 500 characters of output: ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output:
http://queues.webkit.org/results/7929312
WebKit Commit Bot
Comment 4
2011-02-16 20:27:58 PST
Comment on
attachment 82685
[details]
Patch. Clearing flags on attachment: 82685 Committed
r78784
: <
http://trac.webkit.org/changeset/78784
>
WebKit Commit Bot
Comment 5
2011-02-16 20:28:03 PST
All reviewed patches have been landed. Closing bug.
Kenneth Rohde Christiansen
Comment 6
2011-02-17 00:51:50 PST
Yael, you might want to upsteam some of our other tiling patches from our experimental branch
Yael
Comment 7
2011-02-17 04:24:55 PST
(In reply to
comment #6
)
> Yael, you might want to upsteam some of our other tiling patches from our experimental branch
Absolutely! let's talk about what is there and what needs to be upstreamed :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug