Bug 54512 - Implement WKPluginSiteDataManagerClearSiteData
Summary: Implement WKPluginSiteDataManagerClearSiteData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-15 17:28 PST by Anders Carlsson
Modified: 2011-02-15 17:55 PST (History)
0 users

See Also:


Attachments
Patch (12.61 KB, patch)
2011-02-15 17:31 PST, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (12.94 KB, patch)
2011-02-15 17:48 PST, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-02-15 17:28:10 PST
Implement WKPluginSiteDataManagerClearSiteData
Comment 1 Anders Carlsson 2011-02-15 17:31:43 PST
Created attachment 82554 [details]
Patch
Comment 2 Jon Honeycutt 2011-02-15 17:43:35 PST
Comment on attachment 82554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82554&action=review

> Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.cpp:140
> +    callback->invalidate();

Do you want to performCallback()?

> Source/WebKit2/WebProcess/WebProcess.cpp:675
> +}

It doesn't look like this handles the "clear all site data" case.
Comment 3 Anders Carlsson 2011-02-15 17:48:19 PST
Created attachment 82560 [details]
Patch
Comment 4 Anders Carlsson 2011-02-15 17:55:07 PST
Committed r78663: <http://trac.webkit.org/changeset/78663>