Bug 54503 - Plugin mouse capture gets messed up if a dialog pops up while the mouse is down
Summary: Plugin mouse capture gets messed up if a dialog pops up while the mouse is down
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brett Wilson (Google)
Depends on:
Reported: 2011-02-15 15:36 PST by Brett Wilson (Google)
Modified: 2011-02-25 11:14 PST (History)
1 user (show)

See Also:

Patch (4.11 KB, patch)
2011-02-15 15:43 PST, Brett Wilson (Google)
fishd: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wilson (Google) 2011-02-15 15:36:08 PST
The capture logic in WebViewImpl for plugins implicitly sets capture when the mouse goes down on a plugin. If the plugin pops up a dialog in response to that click, the "up" message will be lost and the capture will be stuck.

We should try to recover the capture state if we detect there are no mouse buttons down.
Chromium issue: http://code.google.com/p/chromium/issues/detail?id=73075
Comment 1 Brett Wilson (Google) 2011-02-15 15:43:09 PST
Created attachment 82538 [details]
Comment 2 WebKit Commit Bot 2011-02-21 10:52:12 PST
Comment on attachment 82538 [details]

Rejecting attachment 82538 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
 up to this was:
|Index: src/WebViewImpl.cpp
|--- src/WebViewImpl.cpp	(revision 78540)
|+++ src/WebViewImpl.cpp	(working copy)
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/7937943
Comment 3 Brett Wilson (Google) 2011-02-25 11:14:55 PST
Fixed in r79703