Bug 54448 - Web Inspector: [Text editor] Add updateHighlight method to the highlighter
Summary: Web Inspector: [Text editor] Add updateHighlight method to the highlighter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 53588
  Show dependency treegraph
 
Reported: 2011-02-15 04:46 PST by Andrey Adaikin
Modified: 2011-02-17 05:20 PST (History)
11 users (show)

See Also:


Attachments
Patch (8.83 KB, patch)
2011-02-15 04:50 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2011-02-15 04:46:13 PST
We need a method to effectively update existing highlights in the editor. To do that, we should save pre- and post- conditions of the highlighter for each line.
Comment 1 Andrey Adaikin 2011-02-15 04:50:14 PST
Created attachment 82438 [details]
Patch
Comment 2 Pavel Feldman 2011-02-17 05:11:02 PST
Comment on attachment 82438 [details]
Patch

Please test this thoroughly for the cases with nested highlighters. Also, as we agreed offline, you should add tests for highlighter as your next change.
Comment 3 Pavel Podivilov 2011-02-17 05:20:20 PST
Comment on attachment 82438 [details]
Patch

Clearing flags on attachment: 82438

Committed r78815: <http://trac.webkit.org/changeset/78815>
Comment 4 Pavel Podivilov 2011-02-17 05:20:31 PST
All reviewed patches have been landed.  Closing bug.