Bug 53996 - Move the light source implementations into their own files
Summary: Move the light source implementations into their own files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Renata Hodovan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-08 06:04 PST by Renata Hodovan
Modified: 2011-02-10 04:24 PST (History)
4 users (show)

See Also:


Attachments
Patch (33.53 KB, patch)
2011-02-08 06:24 PST, Renata Hodovan
krit: review-
Details | Formatted Diff | Diff
Patch (34.58 KB, patch)
2011-02-09 03:16 PST, Renata Hodovan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renata Hodovan 2011-02-08 06:04:30 PST
Move of the light source implementations into their own files
Comment 1 Renata Hodovan 2011-02-08 06:24:53 PST
Created attachment 81628 [details]
Patch
Comment 2 Build Bot 2011-02-08 06:53:51 PST
Attachment 81628 [details] did not build on win:
Build output: http://queues.webkit.org/results/7797081
Comment 3 Dirk Schulze 2011-02-09 01:57:09 PST
Comment on attachment 81628 [details]
Patch

Patch looks good. You just forgot to edit the windows project file.
Comment 4 Renata Hodovan 2011-02-09 03:16:18 PST
Created attachment 81785 [details]
Patch
Comment 5 Dirk Schulze 2011-02-10 02:59:19 PST
Comment on attachment 81785 [details]
Patch

The changes look right. Not sure why the patch didn't apply to the Mac builds. Maybe they are out of sync again. r=me
Comment 6 Renata Hodovan 2011-02-10 04:23:57 PST
Comment on attachment 81785 [details]
Patch

Clearing flags on attachment: 81785

Committed r78194: <http://trac.webkit.org/changeset/78194>
Comment 7 Renata Hodovan 2011-02-10 04:24:07 PST
All reviewed patches have been landed.  Closing bug.