WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 53996
Move the light source implementations into their own files
https://bugs.webkit.org/show_bug.cgi?id=53996
Summary
Move the light source implementations into their own files
Renata Hodovan
Reported
2011-02-08 06:04:30 PST
Move of the light source implementations into their own files
Attachments
Patch
(33.53 KB, patch)
2011-02-08 06:24 PST
,
Renata Hodovan
krit
: review-
Details
Formatted Diff
Diff
Patch
(34.58 KB, patch)
2011-02-09 03:16 PST
,
Renata Hodovan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Renata Hodovan
Comment 1
2011-02-08 06:24:53 PST
Created
attachment 81628
[details]
Patch
Build Bot
Comment 2
2011-02-08 06:53:51 PST
Attachment 81628
[details]
did not build on win: Build output:
http://queues.webkit.org/results/7797081
Dirk Schulze
Comment 3
2011-02-09 01:57:09 PST
Comment on
attachment 81628
[details]
Patch Patch looks good. You just forgot to edit the windows project file.
Renata Hodovan
Comment 4
2011-02-09 03:16:18 PST
Created
attachment 81785
[details]
Patch
Dirk Schulze
Comment 5
2011-02-10 02:59:19 PST
Comment on
attachment 81785
[details]
Patch The changes look right. Not sure why the patch didn't apply to the Mac builds. Maybe they are out of sync again. r=me
Renata Hodovan
Comment 6
2011-02-10 04:23:57 PST
Comment on
attachment 81785
[details]
Patch Clearing flags on attachment: 81785 Committed
r78194
: <
http://trac.webkit.org/changeset/78194
>
Renata Hodovan
Comment 7
2011-02-10 04:24:07 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug