Bug 53821 - WebKit2 doesn't hide mouse pointer on keypress
Summary: WebKit2 doesn't hide mouse pointer on keypress
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 15:43 PST by Darin Adler
Modified: 2011-02-04 16:11 PST (History)
0 users

See Also:

Attachments
Patch (7.72 KB, patch)
2011-02-04 15:47 PST, Darin Adler 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-02-04 15:43:52 PST 
WebKit2 doesn't hide mouse pointer on keypress
Comment 1 Darin Adler 2011-02-04 15:47:50 PST 
Created attachment 81311 [details]
Patch
Comment 2 mitz 2011-02-04 15:55:43 PST 
Comment on attachment 81311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81311&action=review

> Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:314
>      if ([nativeEvent type] == NSKeyDown) {

Perhaps the test should be reversed and an early return added so that the entire body is not indented.
Comment 3 Darin Adler 2011-02-04 16:11:10 PST 
Committed r77694: <http://trac.webkit.org/changeset/77694>