WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
53751
Move Android.mk into Source
https://bugs.webkit.org/show_bug.cgi?id=53751
Summary
Move Android.mk into Source
Adam Barth
Reported
2011-02-03 20:33:05 PST
Move Android.mk into Source
Attachments
Patch
(30.62 KB, patch)
2011-02-03 20:33 PST
,
Adam Barth
steveblock
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-02-03 20:33:53 PST
Created
attachment 81181
[details]
Patch
Adam Barth
Comment 2
2011-02-03 20:36:23 PST
Help moving this file would be appreciated.
Adam Barth
Comment 3
2011-02-03 20:36:53 PST
https://lists.webkit.org/pipermail/webkit-dev/2011-January/015683.html
has some additional context.
Steve Block
Comment 4
2011-02-07 10:20:18 PST
Comment on
attachment 81181
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=81181&action=review
> ChangeLog:9 > + I'm sure I've goofed this up in some way.
Thanks Adam. Android hasn't yet synced to a WebKit version beyond the code rearrangement into the Source directory, so we're not currently in a position to test this. However, this change looks reasonable so if you want to submit now, go ahead. We'll take care of making any required changes when we sync to a post-rearrangement revision. Maybe update this commit message to reflect this.
Adam Barth
Comment 5
2011-02-09 00:02:52 PST
> Thanks Adam. Android hasn't yet synced to a WebKit version beyond the code rearrangement into the Source directory, so we're not currently in a position to test this. However, this change looks reasonable so if you want to submit now, go ahead. We'll take care of making any required changes when we sync to a post-rearrangement revision. Maybe update this commit message to reflect this.
Thanks.
Adam Barth
Comment 6
2011-02-09 12:15:46 PST
Committed
r78107
: <
http://trac.webkit.org/changeset/78107
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug